Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-plugin-sharp] fix bluebird.js warning... #4343

Conversation

busticated
Copy link
Contributor

after upgrading to gatsby-plugin-sharp v1.6.37 (from v1.6.25), i started seeing a ton of warnings from the bluebird promise lib:

Generating image thumbnails [============================--] 521/568 44.8 secs 92%
(node:45054) Warning: a promise was created in a handler at /path/to/my/project/node_modules/gatsby-plugin-sharp/index.js:727:28 but was not returned from it, see http://goo.gl/rRqMUw
    at new Promise (/path/to/my/project/node_modules/bluebird/js/release/promise.js:79:10)

this PR fixes the underlying issue and eliminates the warning for me. I'm not sure if there are other places where the promise isn't being returned that my site code simply doesn't hit. If you are aware of any, I'd be happy to address them as well 👍

fixes: Bluebird Warning: a promise was created in a handler but was not returned from it
@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 0e3f79a

https://deploy-preview-4343--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Awww good ol' no default return JavaScript :-)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants