chore(gatsby-source-contentful): upgrade is-online #38862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: maintenance
pieh
commented
Feb 21, 2024
| `trim-lines`, | ||
| `estree-util-to-js`, | ||
| `is-reference`, | ||
| `github-slugger`, | ||
| ].join(`|`) |
There was a problem hiding this comment.
this list was getting messy, so I did sort it lexigraphically
pieh
commented
Feb 21, 2024
Comment on lines
+38
to
+41
| async function isOnline() { | ||
| return (await import(`is-online`)).default() | ||
| } | ||
|
|
There was a problem hiding this comment.
fixed version is ESM-only, hence await import trick
…-in-gatsby-source-contentful
pieh
deleted the
michalpiechowiak/fra-339-upgrade-is-online-in-gatsby-source-contentful
branch
pieh
added a commit
that referenced
this pull request
May 6, 2024
* chore(gatsby-source-contentful): upgrade is-online * test: update esm packages for jest config (cherry picked from commit 89cb129)
pieh
added a commit
that referenced
this pull request
May 6, 2024
* chore(gatsby-source-contentful): upgrade is-online * test: update esm packages for jest config (cherry picked from commit 89cb129) Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing npm audit alert
Documentation
Tests
Related Issues