-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): allow gatsby-adapter-netlify@">=1.0.0 <=1.0.3" for gatsby@<5.12.10 #38758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Dec 15, 2023
2 tasks
pieh
added
topic: adapters
Related to Gatsby Adapters
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Dec 15, 2023
MarcL
approved these changes
Dec 15, 2023
pieh
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Dec 15, 2023
This was referenced Jan 8, 2024
This was referenced May 7, 2024
This was referenced May 9, 2024
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: adapters
Related to Gatsby Adapters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#38745 only allowed
[email protected]
forgatsby@">=5.0.0 <5.12.10"
versions. While that is fine when adapter is auto installed - it cause problems for users that already have lower version of adapter installed - see #38752.This is just quick relaxing of version range and there will be more follow up work done to prevent broken deploys in the future as mentioned in the issue - however that requires more work/time and more testing.
This was tested with monkey-patching adapters code (we do pull adapters manifest from
@latest
npm version, so I just hardcoded this change instead of pulling) and installation still worked fine:Documentation
Tests
Related Issues
Helps with #38752