Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade axios #38698

Merged
merged 5 commits into from
Jan 5, 2024
Merged

chore: upgrade axios #38698

merged 5 commits into from
Jan 5, 2024

Conversation

larowlan
Copy link
Contributor

Description

Axios versions 0.8.1 - 1.5.1 have an CSRF vulnerability
GHSA-wf5p-g6vw-rhxx

Documentation

Tests

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 14, 2023
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 15, 2023
@aar9nk
Copy link

aar9nk commented Nov 17, 2023

We could just write

      headers: headers as AxiosHeaders,

and it would fix the types but I am unsure of the implications! Sorry, if I knew more about gatsby I'd jump in and fix the issue :)

@pieh
Copy link
Contributor

pieh commented Nov 20, 2023

We could just write

      headers: headers as AxiosHeaders,

and it would fix the types but I am unsure of the implications! Sorry, if I knew more about gatsby I'd jump in and fix the issue :)

Yeah, I was just checking if we can just straight up upgrade, but there likely are breaking changes between currently used axios version and latest that need to be addressed and this needs more effort. While I can't jump into addressing that right now I will try to come back to it once my schedule clears up a bit

@pieh pieh changed the title Update to non vulnerable version of axios chore: upgrade axios Jan 4, 2024
@pieh pieh merged commit e2b3ea3 into gatsbyjs:master Jan 5, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants