Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): fix broken DevOverlay when there is no stack trace. #38535

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

pindjur
Copy link
Contributor

@pindjur pindjur commented Sep 8, 2023

Description

We assumed that error have stack property, which caused RuntimeErrors to fail. Since error information is still available in the devtools, we display message to user to check browser console for more info.

Tests

Unit tests

Related Issues

Fixes #38533

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 8, 2023
@pieh pieh added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 3, 2024
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh merged commit c681a9e into gatsbyjs:master Jan 3, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevOverlay is broken when an error does not have a 'stack' property.
2 participants