Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): support builtin modules prefixed with node: on build-html #38516

Merged
merged 11 commits into from
Jan 3, 2024
+5 −2
Merged

fix(gatsby): support builtin modules prefixed with node: on build-html #38516

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
990ef2c
fix(gatsby): support builtin modules prefixed with `node:` on `build-…
chitoku-k Sep 3, 2023
9d5915a
Merge branch 'master' into webpack/node-prefix
chitoku-k Sep 9, 2023
d58f9d5
Merge branch 'master' into webpack/node-prefix
chitoku-k Sep 21, 2023
2d60a87
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 3, 2023
083450a
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 6, 2023
ab60d29
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 17, 2023
89cecb1
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 21, 2023
63525ef
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 24, 2023
bbfc3ea
Merge branch 'master' into webpack/node-prefix
chitoku-k Oct 25, 2023
c6f8a74
Merge branch 'master' into webpack/node-prefix
chitoku-k Dec 9, 2023
b82a612
Merge branch 'master' into webpack/node-prefix
chitoku-k Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/gatsby/src/utils/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,14 +872,17 @@ module.exports = async (
const builtinsExternalsDictionary = builtinModules.reduce(
(acc, builtinModule) => {
if (builtinModulesToTrack.includes(builtinModule)) {
acc[builtinModule] = `commonjs ${path.join(
const builtinModuleTracked = path.join(
program.directory,
`.cache`,
`ssr-builtin-trackers`,
builtinModule
)}`
)
acc[builtinModule] = `commonjs ${builtinModuleTracked}`
acc[`node:${builtinModule}`] = `commonjs ${builtinModuleTracked}`
} else {
acc[builtinModule] = `commonjs ${builtinModule}`
acc[`node:${builtinModule}`] = `commonjs ${builtinModule}`
}
return acc
},
Expand Down