fix(gatsby): don't serve codeframes for files outside of compilation #38059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: core
LekoArts
approved these changes
May 5, 2023
pieh
added a commit
that referenced
this pull request
May 5, 2023
…38059) (#38062) * test: add test case for overlay handlers * fix: don't serve codeframes for files outside of compilation (cherry picked from commit ed5855e) Co-authored-by: Michal Piechowiak <[email protected]>
pieh
added a commit
that referenced
this pull request
May 5, 2023
…38059) (#38063) * test: add test case for overlay handlers * fix: don't serve codeframes for files outside of compilation (cherry picked from commit ed5855e) Co-authored-by: Michal Piechowiak <[email protected]>
This was referenced May 16, 2023
This was referenced May 16, 2023
This was referenced Sep 29, 2023
This was referenced Nov 27, 2023
This was referenced Jan 24, 2024
This was referenced Apr 18, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds additional checks before serving codeframes that are used in error overlay to avoid serving unintended content
Tests
Added test case ensuring we don't serve source files not related/used in current project
Related Issues