-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Allow "gatsby-node" directory for Parcel Compilation #36712
Merged
LekoArts
merged 14 commits into
gatsbyjs:master
from
graysonhicks:fix/ts-gatsby-node-folder-support
Jan 5, 2023
Merged
fix(gatsby): Allow "gatsby-node" directory for Parcel Compilation #36712
LekoArts
merged 14 commits into
gatsbyjs:master
from
graysonhicks:fix/ts-gatsby-node-folder-support
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nhicks/gatsby into fix/ts-gatsby-node-folder-support
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 29, 2022
tyhopp
reviewed
Sep 29, 2022
Co-authored-by: Ty Hopp <[email protected]>
LekoArts
added
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Oct 5, 2022
LekoArts
reviewed
Oct 5, 2022
LekoArts
changed the title
add check for gatsby-node directory and tests in parcel compilation
fix(gatsby): Allow "gatsby-node" directory for Parcel Compilation
Oct 5, 2022
marvinjude
approved these changes
Jan 5, 2023
This was referenced Jan 10, 2023
This was referenced Jan 11, 2023
This was referenced Feb 16, 2023
This was referenced Feb 18, 2023
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since v4.9 Gatsby added TS support to top-level
gatsby-*
files. Users often used agatsby-node
directory to organize lifecycle hooks, which were then imported in togatsby-*
files. An unintended regression of the Parcel compiling code was thatgatsby-node
directories were marked as misnamed (meant to catch issues likegatsby-node.tsx
) with this error:This error is extra confusing because the user does have a
gatsby-node.js/ts
file.Users encountered this on minor upgrades from <
4.9
to >4.9
if they had agatsby-node
directory.Documentation
Documentation is here and shouldn't have to change.