Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): fix bundling image cdn tools #36534

Merged
merged 7 commits into from
Sep 16, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 5, 2022

Description

Currently some IMAGE_CDN utils are failing to bundle correctly, mostly due to dynamic imports that remain unhandled. This adds various aliases and tricks to make it work after bundling

Related Issues

[ch54853]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 5, 2022
@pieh pieh added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 5, 2022
LekoArts
LekoArts previously approved these changes Sep 15, 2022
@LekoArts LekoArts merged commit 0ef331d into master Sep 16, 2022
@LekoArts LekoArts deleted the fix/engines/image-cdn-placeholder branch September 16, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants