-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-sass): Add support for additionalData option #36086
fix(gatsby-plugin-sass): Add support for additionalData option #36086
Conversation
Still WIP - I'm happy to add to the README |
The unit tests are currently failing () because the snapshots need an update. And I agree, the README could use an update. A new heading called |
Let me know how I can make any improvements :) |
README looks good to me, unit tests still need an update though. Do you need help with that? :) |
I'm a little fresh on writing tests, but I gave it a shot :) Let me know if you have any feedback! One thing I'm not 100% on, was the Joi schema. I updated it to reflect the types listed here: https://webpack.js.org/loaders/sass-loader/#additionaldata - but I wasn't sure what part |
The unknown relates to this: https://joi.dev/api/?v=17.6.0#objectunknownallow But since this isn't an object that's not needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Adds additionalData option to
gatsby-plugin-sass
Documentation
https://webpack.js.org/loaders/sass-loader/#additionaldata
Related Issues
Fixes #36085