Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-image): add check for node.gatsbyImage in the getImage helper #35507

Merged
merged 4 commits into from
May 3, 2022

Conversation

TylerBarnes
Copy link
Contributor

With Gatsby's new Image CDN feature we added a new GraphQL field gatsbyImage which is used in place of gatsbyImageData. This PR adds a check for that in the getImage helper.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 27, 2022
@TylerBarnes TylerBarnes added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 27, 2022
wardpeet
wardpeet previously approved these changes Apr 28, 2022
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

veryspry
veryspry previously approved these changes Apr 29, 2022
Copy link
Contributor

@veryspry veryspry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me

@TylerBarnes TylerBarnes merged commit abc6dca into master May 3, 2022
@TylerBarnes TylerBarnes deleted the fix/get-image-for-image-cdn branch May 3, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants