Skip to content

fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks #35246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 29, 2022
Merged

fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks #35246

merged 3 commits into from
Mar 29, 2022

Conversation

@wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Mar 29, 2022

Description

I've found some windows quirks during testing image-cdn.

I've added tests and fixed them.

  1. When excludeDigest was given and the file already got requested, we could end up with a / path and a \ path on windows which would not copy if it's inside public folder
  2. trace-svg with long urls could end up with .. which is not a proper filename on windows.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 29, 2022
@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 29, 2022
@wardpeet wardpeet changed the title fix: windows quirks fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks Mar 29, 2022
pieh
pieh reviewed Mar 29, 2022
View reviewed changes
@pieh pieh merged commit 392d6bc into master Mar 29, 2022
@pieh pieh deleted the fix/windows-quirks branch March 29, 2022 18:33
@gatsbybot gatsbybot mentioned this pull request Mar 31, 2022
Merged
marvinjude pushed a commit that referenced this pull request Mar 31, 2022
@wardpeet @pieh @marvinjude
fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks (#35246)
6257f75 
Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 392d6bc)
marvinjude pushed a commit that referenced this pull request Mar 31, 2022
@gatsbybot @wardpeet
fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks (#35246) (#…
a527891 
…35268)

Co-authored-by: Michal Piechowiak <[email protected]>
(cherry picked from commit 392d6bc)

Co-authored-by: Ward Peeters <[email protected]>
@marvinjude
Copy link
Contributor

marvinjude commented Mar 31, 2022

Published in [email protected], [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieh pieh pieh approved these changes

Assignees

No one assigned

Labels

type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wardpeet @marvinjude @pieh