Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-cli): Re-Add plugin-add functionality #34482

Merged
merged 4 commits into from
Jan 17, 2022
Merged

fix(gatsby-cli): Re-Add plugin-add functionality #34482

merged 4 commits into from
Jan 17, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 13, 2022

Description

The PR #34094 removed gatsby-cli/lib/handlers/plugin-add since it seemed unused. Turns out, it's not: It's used in create-gatsby. So I've copied over the bits from gatsby-recipes that are needed and re-added it. plugin-add should be nearly identical to what it was before, the other files are new/copied over.

Related Issues

Fixes #34477

[sc-44408]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 13, 2022
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 13, 2022
@@ -0,0 +1,86 @@
import reporter from "../reporter"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,193 @@
import * as fs from "fs-extra"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,319 @@
import * as t from "@babel/types"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LekoArts LekoArts marked this pull request as draft January 13, 2022 14:59
@LekoArts LekoArts marked this pull request as ready for review January 14, 2022 07:51

const getValueFromNode = (node: any): any => {
if (t.isTemplateLiteral(node)) {
// @ts-ignore - fix me
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a lot of // @ts-ignore. If you feel strongly about it I can spend time fixing it but I just wanted it to get working 😬

@LekoArts LekoArts merged commit 618b32b into master Jan 17, 2022
@LekoArts LekoArts deleted the fix-34477 branch January 17, 2022 07:52
marvinjude pushed a commit that referenced this pull request Jan 17, 2022
tyhopp pushed a commit that referenced this pull request Jan 17, 2022
@marvinjude
Copy link
Contributor

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a suitable version of gatsby-cli
3 participants