chore(docs): Update tutorial part 1 to reflect changes to add site flow #34427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
aghreed
added
type: documentation
rmatambo8
previously approved these changes
Jan 11, 2022
jxnblk
reviewed
Jan 11, 2022
|
|
||
| <Announcement style={{marginBottom: "1.5rem"}}> | ||
|
|
||
| **Note:** If you are part of more than one GitHub organization, you will need to first select the organization with which the repository resides at this step before selecting the repository itself. | ||
| **Note:** If you are part of more than one GitHub organization, you will need to first select the organization with which the repository resides at this step before selecting the repository itself. |
There was a problem hiding this comment.
FWIW, this indentation looks suspect to me – could also be related to the Announcement component being using inside the parent ol
There was a problem hiding this comment.
With the latest commit on this branch by Rodney, I'm seeing everything work as expected. He is my personal hero today ❤️
aghreed
deleted the
aghreed/sc-42765/update-tutorial-references-to-add-site-flow
branch
moonmeister
added a commit
to moonmeister/gatsby
that referenced
this pull request
Jan 12, 2022
* master: fix(gatsby-core-utils): Re-Export updateSiteMetadata (gatsbyjs#34462) fix(deps): update starters and examples gatsby packages to ^4.5.1 (gatsbyjs#34463) fix(gatsby-dev-cli): Do not ignore engines (gatsbyjs#34461) fix(gatsby): Revert gatsbyjs#33786 (gatsbyjs#34458) fix(deps): update starters and examples - gatsby (gatsbyjs#34449) chore(changelogs): update changelogs (gatsbyjs#34451) Update tutorial part 1 to reflect changes to add site flow (gatsbyjs#34427) preview 2.0 UI changes (gatsbyjs#34440)
rmatambo8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have enabled the new add site experience for all users, it follows that we should update the instructions in the tutorial that reference that flow.
Related Issues
sc-42765
Testing
Many thanks to @rmatambo8 for discovering the indentation issue here that was plaguing me! All looks good to me now locally!