Skip to content

Conversation

@wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Dec 1, 2021

Description

Fixes pathPrefix handling correctly with gatsby-plugin-sitemap.

The generated paths inside the sitemap are prefixed with basePathand the sitemap URLs are prefixed with assetPrefix + pathPrefix like we expect

Documentation

Related Issues

Fixes #34010
Fixes [sc-42532]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 1, 2021
@wardpeet wardpeet added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 1, 2021
@wardpeet wardpeet merged commit 2d1a880 into master Dec 2, 2021
@wardpeet wardpeet deleted the fix/sitemap-asset-name branch December 2, 2021 11:06
@makanti
Copy link

makanti commented Dec 6, 2021

Thanks for solving this @wardpeet, we were facing the exact same issue 🙏

@veryspry sorry to bother you with this but do we have an idea of when the release including this fix will be out?

@LekoArts
Copy link
Contributor

LekoArts commented Dec 9, 2021

@makanti You can use it on the next tag at the moment, the next minor (stable) release goes out next tuesday (2021/12/14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gatsby-plugin-sitemap incorrectly applies assetPath to generated urls

5 participants