-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deprecate gatsby-recipes
#34094
Changes from 7 commits
8c9d092
88b459f
8261e6c
9cff27e
8fcd92b
91ed9f2
ebe7a5b
696d08b
1886d69
2fa9d5d
ec1fdde
21f0934
6585036
e72a11a
c927b9d
d7c5714
f91c232
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
module.exports = api => { | ||
const isTest = api.env(`test`) | ||
|
||
return { | ||
presets: [ | ||
[ | ||
`@babel/env`, | ||
{ | ||
// use ES modules for rollup and commonjs for jest | ||
modules: isTest ? `commonjs` : false, | ||
shippedProposals: true, | ||
targets: { | ||
node: `10.13.0`, | ||
}, | ||
}, | ||
], | ||
`@babel/preset-react`, | ||
], | ||
plugins: [`@babel/plugin-transform-runtime`], | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
const components = require(`./dist/web/components`) | ||
module.exports = components | ||
module.exports = components |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ import isValid from "is-valid-path" | |
import sysPath from "path" | ||
import prompts from "prompts" | ||
import url from "url" | ||
import { updateSiteMetadata } from "gatsby-core-utils" | ||
import { updateInternalSiteMetadata } from "gatsby-core-utils" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The naming of the function confused me with the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seem to be getting this error when running
I need to have a look into why this is happening though, as something in our build system isn't correctly pinning the version of gatsby + gatsby-cli it seems. (setting to the previous version doesn't fix the issue for some reason - should have an update tomorrow). I'm guessing (and unsure if this is always the case, but this change means that the gatsby + gatsby-cli versions must match) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You shouldn’t add gatsby-cli as a dependency to a project. It’s a global CLI package There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be clear we don't have it as a dependency in the package.json, however it's required in the CI system to be installed |
||
import report from "./reporter" | ||
import { getPackageManager, setPackageManager } from "./util/package-manager" | ||
import reporter from "./reporter" | ||
|
@@ -353,7 +353,7 @@ export async function initStarter( | |
) | ||
}) | ||
|
||
await updateSiteMetadata( | ||
await updateInternalSiteMetadata( | ||
{ | ||
name: sitePackageJson?.name || rootPath, | ||
sitePath, | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stub was added in #27725 but never used again. So
plugins
positional was never working, thus I removed this here + removedplugin-add.ts
handler file