fix: add missing dependencies #31837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
merceyz
changed the title
merceyz
force-pushed
the
merceyz/fix/cli-missing-deps
branch
2 times, most recently
from
c1ab4d0 to
eae29b1
Compare
|
Any suggestions for how to fix the failing CI checks? |
TylerBarnes
added
status: needs core review
|
@merceyz try merging master into your branch |
merceyz
force-pushed
the
merceyz/fix/cli-missing-deps
branch
from
924ccef to
b9a3896
Compare
|
I've done that a few times already |
merceyz
force-pushed
the
merceyz/fix/cli-missing-deps
branch
from
b9a3896 to
6378692
Compare
wardpeet
force-pushed
the
merceyz/fix/cli-missing-deps
branch
from
797b712 to
43f69e5
Compare
wardpeet
approved these changes
Sep 6, 2021
wardpeet
added
type: maintenance
merceyz
commented
Sep 6, 2021
starters/blog/package.json
Outdated
| @@ -30,8 +30,7 @@ | |||
| "react-dom": "^17.0.1", | |||
| "react-helmet": "^6.1.0", | |||
| "typeface-merriweather": "0.0.72", | |||
| "typeface-montserrat": "0.0.75", | |||
| "webpack": "^5.35.0" | |||
There was a problem hiding this comment.
@wardpeet I added this because some of the gatsby plugins requires webpack to be provided by the parent, removing it will make them unmet peer dependencies and be rejected by PnP again and cause it to rely on hoisting under node_modules
There was a problem hiding this comment.
Interesting cause we don't want that people install webpack, i'll see why it's necessary here.
merceyz
commented
Sep 6, 2021
3 tasks
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* chore(starters): avoid using npm in scripts * ci: test with no fallbacks * fix: add missing dependencies * update Co-authored-by: Ward Peeters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm removing the old dependency fallback to
gatsbyfrom the PnP runtime since it causes hard to debug issues and hides undeclared dependencies, this PR adds the missing dependencies uncovered by the changes.Related Issues
yarnpkg/berry#3004