Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish-starters): fix syntax #29926

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fix(publish-starters): fix syntax #29926

merged 1 commit into from
Mar 2, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 2, 2021

Apparently == doesn't work :)

so reverting to single = we had before for line 38 and applying it in skip check

should fix:

./scripts/publish-starters.sh: 22: [: gatsby-starter-wordpress-blog: unexpected operator
./scripts/publish-starters.sh: 38: [: null: unexpected operator

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 2, 2021
@pieh pieh added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 2, 2021
@pieh pieh merged commit cd39339 into master Mar 2, 2021
@pieh pieh deleted the actually-use-single-equal branch March 2, 2021 17:23
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
actually seems like == is no no (gatsbyjs#29926)
0ada3e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

Assignees
No one assigned
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieh @laurieontech