-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to remark 13 #29678
Merged
Merged
feat: upgrade to remark 13 #29678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 22, 2021
vladar
added
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: remark/mdx
Related to Markdown, remark & MDX ecosystem
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 22, 2021
vladar
commented
Feb 22, 2021
Comment on lines
+634
to
+636
<li> | ||
<p><a href=\\"/my%20little%20pony/#third-title\\">third title</a></p> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pre-13.0 change (happens even with 12.0) Makes sense to me because now top-level list items have consistent markup (expand above to compare with the item having a sub-list)
vladar
changed the title
chore(gatsby-transformer-remark): ugprade remark-related deps
chore: ugprade remark-related deps
Feb 22, 2021
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
If implemented, this proposed work would break functionality for older versions of Gatsby
topic: remark/mdx
Related to Markdown, remark & MDX ecosystem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded remark-related packages. Listed all known dom tree changes in the discussion: #30385
BREAKING CHANGES:
Plugin deps updated:
List of remark plugins compatible with v13:
https://github.com/remarkjs/remark/blob/main/doc/plugins.md#list-of-plugins
Discussion
See umbrella discussion #30385