Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to remark 13 #29678

Merged
merged 35 commits into from
Apr 9, 2021
Merged

feat: upgrade to remark 13 #29678

merged 35 commits into from
Apr 9, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Feb 22, 2021

Description

Upgraded remark-related packages. Listed all known dom tree changes in the discussion: #30385

BREAKING CHANGES:

Plugin deps updated:

  • ✅ gatsby-transformer-remark
  • ✅ gatsby-remark-autolink-headers
  • ✅ gatsby-remark-code-repls
  • ✅ gatsby-remark-copy-linked-files
  • ⛔ gatsby-remark-custom-blocks (blocked by remark@next (13) zestedesavoir/zmarkdown#416)
  • ✅ gatsby-remark-embed-snippet
  • ✅ gatsby-remark-graphviz
  • ✅ gatsby-remark-images
  • ✅ gatsby-remark-images-contentful
  • ✅ gatsby-remark-katex
  • ✅ gatsby-remark-prismjs
  • ✅ gatsby-remark-responsive-iframe
  • ✅ gatsby-remark-smartypants

List of remark plugins compatible with v13:
https://github.com/remarkjs/remark/blob/main/doc/plugins.md#list-of-plugins

Discussion

See umbrella discussion #30385

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@vladar vladar added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 22, 2021
Comment on lines +634 to +636
<li>
<p><a href=\\"/my%20little%20pony/#third-title\\">third title</a></p>
</li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-13.0 change (happens even with 12.0) Makes sense to me because now top-level list items have consistent markup (expand above to compare with the item having a sub-list)

@vladar vladar changed the title chore(gatsby-transformer-remark): ugprade remark-related deps chore: ugprade remark-related deps Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants