Skip to content

feat(gatsby-plugin-image): Allow image helpers to take other node types #29625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions packages/gatsby-plugin-image/src/components/__tests__/hooks.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
import { Node } from "gatsby"
import { getSrc, getSrcSet, getImage, IGatsbyImageData } from "../../"

const imageData: IGatsbyImageData = {
images: {
fallback: {
src: `imagesrc.jpg`,
srcSet: `imagesrcset.jpg 1x`,
},
},
layout: `constrained`,
width: 1,
height: 2,
}

const node: Node = {
id: ``,
parent: ``,
children: [],
internal: {
type: ``,
contentDigest: ``,
owner: ``,
},
}

const dataParent = {
...node,
gatsbyImageData: imageData,
}

const fileNode = {
...node,
childImageSharp: dataParent,
}

describe(`The image helper functions`, () => {
describe(`getImage`, () => {
it(`returns the same data if passed gatsbyImageData`, () => {
expect(getImage(imageData)).toEqual(imageData)
})

it(`gets an image from a FileNode`, () => {
expect(getImage(fileNode)?.images.fallback?.src).toEqual(`imagesrc.jpg`)
})

it(`gets an image from an IGatsbyImageDataParent`, () => {
expect(getImage(dataParent)?.images.fallback?.src).toEqual(`imagesrc.jpg`)
})
it(`returns undefined from an invalid object`, () => {
expect(getImage(node)).toBeUndefined()
})

it(`returns undefined when passed a number`, () => {
expect(getImage((1 as any) as Node)).toBeUndefined()
})

it(`returns undefined when passed undefined`, () => {
expect(getImage((undefined as any) as Node)).toBeUndefined()
})
})

describe(`getSrc`, () => {
it(`gets src from an image data object`, () => {
expect(getSrc(imageData)).toEqual(`imagesrc.jpg`)
})

it(`gets src from a FileNode`, () => {
expect(getSrc(fileNode)).toEqual(`imagesrc.jpg`)
})

it(`gets src from an IGatsbyImageDataParent`, () => {
expect(getSrc(dataParent)).toEqual(`imagesrc.jpg`)
})

it(`returns undefined from an invalid object`, () => {
expect(getSrc(node)).toBeUndefined()
})
it(`returns undefined when passed undefined`, () => {
expect(getSrc((undefined as any) as Node)).toBeUndefined()
})

it(`returns undefined when passed a number`, () => {
expect(getSrc((1 as any) as Node)).toBeUndefined()
})
})

describe(`getSrcSet`, () => {
it(`gets srcSet from am image data object`, () => {
expect(getSrcSet(imageData)).toEqual(`imagesrcset.jpg 1x`)
})

it(`gets srcSet from a FileNode`, () => {
expect(getSrcSet(fileNode)).toEqual(`imagesrcset.jpg 1x`)
})

it(`gets srcSet from an IGatsbyImageDataParent`, () => {
expect(getSrcSet(dataParent)).toEqual(`imagesrcset.jpg 1x`)
})

it(`returns undefined from an invalid object`, () => {
expect(getSrcSet(node)).toBeUndefined()
})

it(`returns undefined when passed undefined`, () => {
expect(getSrcSet((undefined as any) as Node)).toBeUndefined()
})

it(`returns undefined when passed a number`, () => {
expect(getSrcSet((1 as any) as Node)).toBeUndefined()
})
})
})
37 changes: 30 additions & 7 deletions packages/gatsby-plugin-image/src/components/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,41 @@ export function storeImageloaded(cacheKey?: string): void {
export function hasImageLoaded(cacheKey: string): boolean {
return imageCache.has(cacheKey)
}

export type IGatsbyImageDataParent<T = never> = T & {
gatsbyImageData: IGatsbyImageData
}
export type FileNode = Node & {
childImageSharp?: Node & {
gatsbyImageData?: IGatsbyImageData
childImageSharp?: IGatsbyImageDataParent<Node>
}

const isGatsbyImageData = (
// eslint-disable-next-line @typescript-eslint/no-explicit-any
node: IGatsbyImageData | any
): node is IGatsbyImageData =>
// 🦆 check for a deep prop to be sure this is a valid gatsbyImageData object
Boolean(node?.images?.fallback?.src)

const isGatsbyImageDataParent = <T>(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
node: IGatsbyImageDataParent<T> | any
): node is IGatsbyImageDataParent<T> => Boolean(node?.gatsbyImageData)

type ImageDataLike = FileNode | IGatsbyImageDataParent | IGatsbyImageData
export const getImage = (node: ImageDataLike): IGatsbyImageData | undefined => {
if (isGatsbyImageData(node)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for making isGatsbyImageData and isGatsbyImageDataParent? It seems like checking for existence inside this function would be equivalent? I noticed those functions are exported, are they meant for plugins to be able to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making them type guard functions allows type narrowing in TS. I exported them so they could be unit tested, but in the end just tested the getImage function itself so I could remove the export.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Too bad we can't get the benefit without the extra functions. Would make it easier to scan.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's easier to read with function name!

return node
}
if (isGatsbyImageDataParent(node)) {
return node.gatsbyImageData
}
return node?.childImageSharp?.gatsbyImageData
}

export const getImage = (file: FileNode): IGatsbyImageData | undefined =>
file?.childImageSharp?.gatsbyImageData
export const getSrc = (node: ImageDataLike): string | undefined =>
getImage(node)?.images?.fallback?.src

export const getSrc = (file: FileNode): string | undefined =>
file?.childImageSharp?.gatsbyImageData?.images?.fallback?.src
export const getSrcSet = (node: ImageDataLike): string | undefined =>
getImage(node)?.images?.fallback?.srcSet

export function getWrapperProps(
width: number,
Expand Down
1 change: 1 addition & 0 deletions packages/gatsby-plugin-image/src/index.browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export { LaterHydrator } from "./components/later-hydrator"
export {
getImage,
getSrc,
getSrcSet,
getImageData,
withArtDirection,
IArtDirectedImage,
Expand Down
1 change: 1 addition & 0 deletions packages/gatsby-plugin-image/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export { StaticImage } from "./components/static-image.server"
export {
getImage,
getSrc,
getSrcSet,
getImageData,
withArtDirection,
IArtDirectedImage,
Expand Down