-
Notifications
You must be signed in to change notification settings - Fork 10.3k
feat(gatsby-plugin-image): Allow image helpers to take other node types #29625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
113 changes: 113 additions & 0 deletions
113
packages/gatsby-plugin-image/src/components/__tests__/hooks.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
import { Node } from "gatsby" | ||
import { getSrc, getSrcSet, getImage, IGatsbyImageData } from "../../" | ||
|
||
const imageData: IGatsbyImageData = { | ||
images: { | ||
fallback: { | ||
src: `imagesrc.jpg`, | ||
srcSet: `imagesrcset.jpg 1x`, | ||
}, | ||
}, | ||
layout: `constrained`, | ||
width: 1, | ||
height: 2, | ||
} | ||
|
||
const node: Node = { | ||
id: ``, | ||
parent: ``, | ||
children: [], | ||
internal: { | ||
type: ``, | ||
contentDigest: ``, | ||
owner: ``, | ||
}, | ||
} | ||
|
||
const dataParent = { | ||
...node, | ||
gatsbyImageData: imageData, | ||
} | ||
|
||
const fileNode = { | ||
...node, | ||
childImageSharp: dataParent, | ||
} | ||
|
||
describe(`The image helper functions`, () => { | ||
describe(`getImage`, () => { | ||
it(`returns the same data if passed gatsbyImageData`, () => { | ||
expect(getImage(imageData)).toEqual(imageData) | ||
}) | ||
|
||
it(`gets an image from a FileNode`, () => { | ||
expect(getImage(fileNode)?.images.fallback?.src).toEqual(`imagesrc.jpg`) | ||
}) | ||
|
||
it(`gets an image from an IGatsbyImageDataParent`, () => { | ||
expect(getImage(dataParent)?.images.fallback?.src).toEqual(`imagesrc.jpg`) | ||
}) | ||
it(`returns undefined from an invalid object`, () => { | ||
expect(getImage(node)).toBeUndefined() | ||
}) | ||
|
||
it(`returns undefined when passed a number`, () => { | ||
expect(getImage((1 as any) as Node)).toBeUndefined() | ||
}) | ||
|
||
it(`returns undefined when passed undefined`, () => { | ||
expect(getImage((undefined as any) as Node)).toBeUndefined() | ||
}) | ||
}) | ||
|
||
describe(`getSrc`, () => { | ||
it(`gets src from an image data object`, () => { | ||
expect(getSrc(imageData)).toEqual(`imagesrc.jpg`) | ||
}) | ||
|
||
it(`gets src from a FileNode`, () => { | ||
expect(getSrc(fileNode)).toEqual(`imagesrc.jpg`) | ||
}) | ||
|
||
it(`gets src from an IGatsbyImageDataParent`, () => { | ||
expect(getSrc(dataParent)).toEqual(`imagesrc.jpg`) | ||
}) | ||
|
||
it(`returns undefined from an invalid object`, () => { | ||
expect(getSrc(node)).toBeUndefined() | ||
}) | ||
it(`returns undefined when passed undefined`, () => { | ||
expect(getSrc((undefined as any) as Node)).toBeUndefined() | ||
}) | ||
|
||
it(`returns undefined when passed a number`, () => { | ||
expect(getSrc((1 as any) as Node)).toBeUndefined() | ||
}) | ||
}) | ||
|
||
describe(`getSrcSet`, () => { | ||
it(`gets srcSet from am image data object`, () => { | ||
expect(getSrcSet(imageData)).toEqual(`imagesrcset.jpg 1x`) | ||
}) | ||
|
||
it(`gets srcSet from a FileNode`, () => { | ||
expect(getSrcSet(fileNode)).toEqual(`imagesrcset.jpg 1x`) | ||
}) | ||
|
||
it(`gets srcSet from an IGatsbyImageDataParent`, () => { | ||
expect(getSrcSet(dataParent)).toEqual(`imagesrcset.jpg 1x`) | ||
}) | ||
|
||
it(`returns undefined from an invalid object`, () => { | ||
expect(getSrcSet(node)).toBeUndefined() | ||
}) | ||
|
||
it(`returns undefined when passed undefined`, () => { | ||
expect(getSrcSet((undefined as any) as Node)).toBeUndefined() | ||
}) | ||
|
||
it(`returns undefined when passed a number`, () => { | ||
expect(getSrcSet((1 as any) as Node)).toBeUndefined() | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for making isGatsbyImageData and isGatsbyImageDataParent? It seems like checking for existence inside this function would be equivalent? I noticed those functions are exported, are they meant for plugins to be able to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making them type guard functions allows type narrowing in TS. I exported them so they could be unit tested, but in the end just tested the
getImage
function itself so I could remove the export.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Too bad we can't get the benefit without the extra functions. Would make it easier to scan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's easier to read with function name!