feat(gatsby): decouple html activities #28648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
commented
Dec 16, 2020
| if (stage !== `develop-html`) { | ||
| await deleteRenderer(rendererPath) | ||
| } | ||
| await deleteRenderer(rendererPath) |
There was a problem hiding this comment.
This is now done inside start-server
wardpeet
added
topic: SSG*
type: maintenance
vladar
reviewed
Dec 16, 2020
| @@ -495,7 +495,7 @@ module.exports = { | |||
| // Let renderDevHTML figure it out. | |||
| page: undefined, | |||
| store, | |||
| htmlComponentRendererPath: `${program.directory}/public/render-page.js`, | |||
| htmlComponentRendererPath: pageRenderer, | |||
There was a problem hiding this comment.
I think pageRenderer will be undefined here for the else codepath on lines 147-153:
let pageRenderer: string
if (process.env.GATSBY_EXPERIMENTAL_DEV_SSR) {
// ...
pageRenderer = await buildRenderer(program, Stage.DevelopHTML)
// ...
} else {
// we don't set `pageRenderer` value in this codepathThere was a problem hiding this comment.
It should be in the same process.env.GATSBY_EXPERIMENTAL_DEV_SSR, right? I've tested it and didn't have an issue.
There was a problem hiding this comment.
Oh, true. Didn't see the this if. Still surprised TS doesn't complain about this. But it's probably because renderDevHTML is not fully typed.
vladar
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decouple html ssr bundling from rendering pages to get better metrics on where html rendering is slow.
Documentation
Related Issues