feat(gatsby): add preload headers for critical resources so those can started fetching before common.js is fetched #28460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: resource loading*
and removed
status: triage needed
pieh
commented
Dec 3, 2020
pieh
commented
Dec 3, 2020
…n started fetching before common.js is fetched
pieh
force-pushed
the
feat/develop/add-preload-headers
branch
from
6ceae00 to
d9273dd
Compare
…pages too, ensure static query hashes have no duplicates
wardpeet
approved these changes
Dec 7, 2020
wardpeet
changed the title
pieh
added a commit
that referenced
this pull request
Dec 7, 2020
… started fetching before common.js is fetched (#28460) (#28521) (cherry picked from commit b4a76f5) Co-authored-by: Michal Piechowiak <[email protected]>
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
… started fetching before common.js is fetched (gatsbyjs#28460)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development runtime currently has network request waterfall where we wait to fetch critical resources to render a page until
common.jsis fetched, parsed and executed which triggers fetching those resources.Adding preload header allow us to avoid network request waterfalls
Comparisons:
Chrome dev tools, networks tab (slow 3g):
Master:
This PR:
Webpagetest
First contentful paint
Running
in dev tools console (with
slow-3gthrothling) result in:(above was from single runs, so take it with grain of salt)
[ch20207]