chore(gatsby-source-contentful): drop last usages of lodash #28441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
commented
Dec 2, 2020
| @@ -178,11 +176,8 @@ const resolveFixed = (image, options) => { | |||
| ) | |||
| }) | |||
|
|
|||
| // Sort sizes for prettiness. | |||
| const sortedSizes = _.sortBy(filteredSizes) | |||
There was a problem hiding this comment.
The array is initialized ordered. It is only pruned, not shuffled / added. So this sort should be a noop in any case.
There was a problem hiding this comment.
This warrants a comment that fixedSizes is expected to be sorted in the first place.
pvdz
commented
Dec 2, 2020
| } | ||
|
|
||
| // Sort sizes for prettiness. | ||
| const sortedSizes = _.sortBy(filteredSizes) |
There was a problem hiding this comment.
This sort is similar to above except the condition before it does not exist in the other case.
The condition will only add the current width if it doesn't already exist here. And the loop before will cull any widths that are greater than this width. So either way, the width should be the last element in the list. This means the .sortBy is equally useless here and is safe to drop.
pvdz
added
topic: source-contentful
vladar
reviewed
Dec 2, 2020
pvdz
commented
Dec 2, 2020
pvdz
commented
Dec 2, 2020
Co-authored-by: Vladimir Razuvaev <[email protected]>
|
Ok. This branch switching is a little funky :/ |
vladar
approved these changes
Dec 2, 2020
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…#28441) * chore(gatsby-source-contentful): drop last usages of lodash * Update packages/gatsby-source-contentful/src/extend-node-type.js Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: Vladimir Razuvaev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the last remaining cases of lodash from this file.
See inline comments for clarification