fix(create-gatsby): Improve install (#28318) #28406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4fbded2)
gatsbot
bot
added
the
status: triage needed
pieh
reviewed
Dec 1, 2020
| import { stripIndent } from "common-tags" | ||
| import { trackCli } from "./tracking" | ||
| import crypto from "crypto" | ||
| import { reporter } from "./reporter" |
There was a problem hiding this comment.
There was merge conflict here due to neighbouring
import { setSiteMetadata } from "./site-metadata"
added by #28324 which is not backported and was merged before this PR
| stripIndent` | ||
| ${w(`🎉 `)}Your new Gatsby site ${c.bold( | ||
| data.project | ||
| )} has been successfully bootstrapped | ||
| )} has been successfully created | ||
| at ${c.bold(path.resolve(data.project))}. |
There was a problem hiding this comment.
There was merge conflict here due to change from path.resolve(data.project) to fullPath added by #28324 which is not backported and was merged before this PR
|
|
||
| if (plugins.length) { | ||
| console.log(c.bold(`${w(`🔌 `)}Installing plugins...`)) | ||
| reporter.info(`${w(`🔌 `)}Setting-up plugins...`) | ||
| await installPlugins(plugins, pluginConfig, path.resolve(data.project), []) |
There was a problem hiding this comment.
There was merge conflict here due to change from path.resolve(data.project) to fullPath added by #28324 which is not backported and was merged before this PR
pieh
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #28318 to the 2.28 release branch
(cherry picked from commit 4fbded2)