feature(gatsby): Enable partial releases of flags to a % of users #28387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: feature or enhancement
KyleAMathews
commented
Nov 30, 2020
| @@ -17,8 +42,17 @@ export interface IFlag { | |||
| // resolved and ~50+ people have tested it, experimental should be set to | |||
| // false. | |||
| experimental: boolean | |||
| // Generally just return true. | |||
There was a problem hiding this comment.
how the testFitness function works
|
|
||
| if (optedInFlags.size > 0) { | ||
| message += `\n` | ||
| message += `We're shipping new features! For final testing, we're rolling them out first to a small % of Gatsby users |
There was a problem hiding this comment.
message when we opt a site in
| lodash: `>=4.9`, | ||
| } | ||
| if ( | ||
| satisfiesSemvers(semver) && |
There was a problem hiding this comment.
how semver filtering would work — in a real flag, we'd generally also return true if it passes semver but doesn't pass the opt-in
KyleAMathews
commented
Nov 30, 2020
|
Is it possible to let ssr use the same hot-module-overlay and fast-refresh overlay when an error occurs instead of doing our own? |
|
Is it possible to output enabled flags in |
KyleAMathews
force-pushed
the
opt-in-flags
branch
from
da5b4e8 to
09ea3b4
Compare
pieh
reviewed
Dec 10, 2020
pieh
reviewed
Dec 10, 2020
pieh
reviewed
Dec 10, 2020
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…tsbyjs#28387) * feature(gatsby): Enable partial releases of flags to a % of users * switch to a general 'testFitness' function for one-off checks on flags * typescripting * cleanup comment * Add FAST_REFRESH * Opt-in QoD & LazyImages for ~10% of users * update snapshot for newline * includePrelease for semver checks * no double isCI in IFlag interface * type unknownConfigFlags array * don't treat unfit flags are unknown * Update packages/gatsby/src/utils/flags.ts * fix lint Co-authored-by: Michal Piechowiak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll start with rolling out QUERY_ON_DEMAND & LAZY_IMAGES to 10% of users.
A user can opt out of the roll-out by setting the flag to false in their gatsby-config.js.