perf(gatsby-source-contentful): fix unguided search in expensive loop #28375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: source-contentful
axe312ger
approved these changes
Nov 30, 2020
|
Wow! 🎉 |
pieh
pushed a commit
that referenced
this pull request
Dec 1, 2020
…e lists (#28375) (#28404) (cherry picked from commit d9904ac) Co-authored-by: Peter van der Zee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The part first builds up a set of existing names and then loops through the received data to find new data.
A site I was testing with had n at 80k elements. So this was doing an unguided search through 80k elements for 80k times.
This little fix literally drops this 5 minute step in incremental builds (and perhaps others) for that case, down to be sub-second.