test(create-gatsby): snapshot plugins-options-form and tiny refactoring #28366

mfrachet · 2020-11-30T11:16:27Z

Description

Snapshotting output of makePluginConfigQuestions and add a tiny refacto

gillkyle

I like reading through these to see what you change. This one looks pretty straightforward to me, testing the output of makePluginConfigQuestions so we don't do something that breaks what gets piped into the enquirer form 👍

mfrachet · 2020-12-01T07:57:33Z

Thanks for the feedback 😊 I (we actually 😬 ) tried to test from the enquirer standpoint and got in trouble when going in the CI. We then decided to step back and just test the different functions to make sure everything looks okay 😊

ascorbic

Looks great! Just a couple of typos

packages/create-gatsby/src/__tests__/plugin-options-form.ts

ascorbic · 2020-12-01T09:33:41Z

packages/create-gatsby/src/plugin-options-form.ts

+const schemaToChoice = ([name, option]: [string, Schema]): IChoice => {
+  const hasDefaultValue =
+    option.flags?.default &&
+    supportedOptionTypes.includes(typeof option.flags?.default)


I realise this was how it was before, but I do wonder if there's a better way to do this, using the schema rather than checking the type of the default value

a side note on that: right now, IIRC, none of the elements that are required have a default value 🤔 . This is a computation that lives there "for nothing" for now I would say :/

Good point. Most of them aren't likely to either, because if there's a default it won't need to be required

Co-authored-by: Matt Kane <[email protected]>

$mfrachet$

gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 30, 2020

$@mfrachet$ mfrachet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 30, 2020

$@mfrachet$ mfrachet requested a review from ascorbic November 30, 2020 11:17

test(create-gatsby): snapshotting plugin-options-form

43106ca

$@mfrachet$ mfrachet force-pushed the mfrachet/plugins-options-form-tests branch from 95b72f8 to 43106ca Compare November 30, 2020 11:18

gillkyle previously approved these changes Nov 30, 2020

View reviewed changes

ascorbic previously approved these changes Dec 1, 2020

View reviewed changes

Apply suggestions from code review

10bbc17

Co-authored-by: Matt Kane <[email protected]>

$@mfrachet$ mfrachet dismissed stale reviews from ascorbic and gillkyle via 10bbc17 December 1, 2020 09:35

$@mfrachet$ mfrachet requested review from ascorbic and gillkyle December 1, 2020 09:37

ascorbic approved these changes Dec 1, 2020

View reviewed changes

$@mfrachet$ mfrachet merged commit a19a76d into master Dec 1, 2020

delete-merged-branch bot deleted the mfrachet/plugins-options-form-tests branch December 1, 2020 11:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(create-gatsby): snapshot plugins-options-form and tiny refactoring #28366

test(create-gatsby): snapshot plugins-options-form and tiny refactoring #28366

$@mfrachet$ mfrachet commented Nov 30, 2020

gillkyle left a comment

mfrachet commented Dec 1, 2020

ascorbic left a comment

ascorbic Dec 1, 2020

$@mfrachet$ mfrachet Dec 1, 2020

ascorbic Dec 1, 2020

test(create-gatsby): snapshot plugins-options-form and tiny refactoring #28366

test(create-gatsby): snapshot plugins-options-form and tiny refactoring #28366

Conversation

mfrachet commented Nov 30, 2020

Description

gillkyle left a comment

Choose a reason for hiding this comment

mfrachet commented Dec 1, 2020

ascorbic left a comment

Choose a reason for hiding this comment

ascorbic Dec 1, 2020

Choose a reason for hiding this comment

mfrachet Dec 1, 2020

Choose a reason for hiding this comment

ascorbic Dec 1, 2020

Choose a reason for hiding this comment

$@mfrachet$ mfrachet commented Nov 30, 2020

$@mfrachet$ mfrachet Dec 1, 2020