Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmarks): upgrade contentful for wib #28335

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

KyleAMathews
Copy link
Contributor

They're both behind on major releases

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 27, 2020
@KyleAMathews KyleAMathews added topic: benchmarks Related to sites used for benchmarking (`benchmarks` directory) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 27, 2020
@TylerBarnes
Copy link
Contributor

WP will require some additional steps, the benchmark gql queries will need to be updated and the WP backends will need to have their plugins updated.

@pvdz
Copy link
Contributor

pvdz commented Nov 30, 2020

Contentful is probably fine. Were you able to test it?

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented Dec 1, 2020 via email

@KyleAMathews
Copy link
Contributor Author

Ok tested the Contentful benchmark locally and it built just fine.

I've removed WordPress as that needs more work externally.

@pvdz pvdz changed the title chore(gatsby): upgrade wordpress/contentful benchmarks chore(benchmarks): upgrade contentful for wib Dec 2, 2020
@pvdz pvdz added the topic: source-contentful Related to Gatsby's integration with Contentful label Dec 2, 2020
@pvdz pvdz merged commit af60da0 into master Dec 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-benchmarks branch December 2, 2020 08:01
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* chore(gatsby): upgrade wordpress/contentful benchmarks

* Don't update wordpress benchmark atm

* Bump to yesterday's publish

Co-authored-by: Peter van der Zee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: benchmarks Related to sites used for benchmarking (`benchmarks` directory) topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants