Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: (gatsby-cli) Add a CLI command for listing plugins #28018

Merged
merged 13 commits into from
Dec 1, 2020

Conversation

laurieontech
Copy link
Contributor

@laurieontech laurieontech commented Nov 12, 2020

The command makes use of existing gatsby recipe provider functionality.

[ch17790]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 12, 2020
@laurieontech laurieontech added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 12, 2020
@laurieontech laurieontech marked this pull request as ready for review November 13, 2020 14:59
Copy link
Contributor

@gillkyle gillkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this plays nicely with local plugins (though maybe I'm the only one who uses those haha), but I've also had some trouble testing this reliably so I'd be happily disputed on that point.

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it. No clue why I didn't approve this earlier, sorry about that!

@@ -400,15 +401,21 @@ function buildLocalCommands(cli: yargs.Argv, isLocalSite: boolean): void {
builder: yargs =>
yargs
.positional(`cmd`, {
choices: [`docs`],
describe: "Valid commands include `docs`.",
choices: [`docs`, `ls`],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed now, but I wonder if we should add list as an alias for ls. Windows people might not know what ls means

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough and easy to do. Let’s get this in and we can add it in the next pass.

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@laurieontech laurieontech merged commit 0e4d026 into master Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the plugin-list branch December 1, 2020 12:27
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
)

* initial commit

* initial gatsby list functionality

* fix linter

* use all, but pass a flag

* add tests

* Update integration-tests/gatsby-cli/gatsby-sites/gatsby-plugin/package.json

* fix log destructure

* use different not syntax

* Refactor to move plugin commands out of gatsby package

* linter

* instead of showing the whole error let's show a more helpful message

Co-authored-by: gatsbybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants