breaking(gatsby-plugin-postcss): Upgrade gatsby-plugin-postcss to PostCSS 8 #26947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is supposed to solve #26939
gatsbot
bot
added
the
status: triage needed
LekoArts
added
type: feature or enhancement
LekoArts
added
status: blocked
|
@LekoArts what are the next steps on this PR? Seems like it just needs a review? |
|
@chlorophyllkid Thanks for working on this. I believe we would want |
|
Wouldn't that mean the install instructions of the plugin itself would need a change too? |
|
Correct. But either way this will be a breaking change. This way we'll be letting people choose the postcss version that's compatible with their plugins. |
|
Yeah, we'll be releasing a new major version then so the breaking change is okay 👍 |
|
Alright, in that case I'll update the PR later. 👍🏼 |
wardpeet
changed the title
|
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…tCSS 8 (gatsbyjs#26947) Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Lennart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating
postcss-loaderand addingpostcssto dependencies forgatsby-plugin-postcss.Related Issues
Fixes #26939