Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-image): Add jest-matchmedia-mock to replace DIY mock #26118

Merged
merged 1 commit into from
Jul 30, 2020
Merged

chore(gatsby-image): Add jest-matchmedia-mock to replace DIY mock #26118

merged 1 commit into from
Jul 30, 2020

Conversation

polarathene
Copy link
Contributor

@polarathene polarathene commented Jul 30, 2020 •
edited
Loading

Better for maintenance, but also because I need a better API surface of matchMedia() for a gatsby-image PR that fails tests otherwise. Better than expanding on the current DIY mock I think.

@polarathene
chore: Add jest-matchmedia-mock to replace DIY mock
374919a 
Better for maintenance, but also because I need a better API surface of `matchMedia()` for a `gatsby-image` PR that uses it and fails tests otherwise.
@polarathene polarathene requested a review from a team as a code owner July 30, 2020 02:39
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@polarathene polarathene requested a review from pvdz July 30, 2020 03:09
This was referenced Jul 30, 2020
Closed
Closed
pvdz
pvdz approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for separating that change. This looks good to me and tests are passing 💜

@pvdz pvdz merged commit b8e1e8d into gatsbyjs:master Jul 30, 2020
@ascorbic ascorbic removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@pvdz pvdz added the topic: media Related to gatsby-plugin-image, or general image/media processing topics label Jul 30, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
chore: Add jest-matchmedia-mock to replace DIY mock (gatsbyjs#26118)
6e723df 
Better for maintenance, but also because I need a better API surface of `matchMedia()` for a `gatsby-image` PR that uses it and fails tests otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polarathene @pvdz @ascorbic