Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Monorepo cleanup #24114

Merged
merged 7 commits into from
May 20, 2020
Merged

chore(gatsby): Monorepo cleanup #24114

merged 7 commits into from
May 20, 2020

Conversation

freiksenet
Copy link
Contributor

Description

  • Remove unused package
  • Make TypeScript part of babel-preset-gatsby
  • Remove unneeded peer dependency of packages/gatsby dependencies
  • Add missing dev and normal dependencies (mostly babel stuff)

@freiksenet
Monorepo cleanup
fa48430 
- Remove unused package
- Make TypeScript part of babel-preset-gatsby
- Remove unneeded peer dependency of `packages/gatsby` dependencies
- Add missing dev and normal dependencies (mostly babel stuff)
@freiksenet freiksenet requested review from a team as code owners May 15, 2020 11:36
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 15, 2020
pvdz
pvdz previously approved these changes May 15, 2020
View reviewed changes
@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 18, 2020
wardpeet
wardpeet suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep peerdeps to [email protected] for now as it's our way to tell people that plugins are available for that gatsby version. We probably want a different way to do this instead.

wardpeet
wardpeet approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's get this in. I wonder if we should deprecate graphql-skip-limit on npm as well.

@gatsbybot gatsbybot merged commit 3aad172 into master May 20, 2020
@wardpeet wardpeet deleted the add-missing-dependencies branch May 20, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freiksenet @pvdz @wardpeet @blainekasten @gatsbybot