Update prettier #22520

MichaelDeBoey · 2020-03-23T23:42:43Z

Update prettier to latest version
Run yarn format from root of project
Remove prettier-ignore for nested markdown (see chore(www) Update nested markdown when prettier is upgraded to 1.19.2/1.20.0 #21743)

vladar

Thanks for the PR! I have one change request:

Prettier 2.0 had changed default value for arrowParens option from "avoid" to "always" (link). But we'd prefer to keep the old style for now.

So could you please add arrowParens: "avoid" to .prettierrc which matches previous default. This should also reduce the number of affected files in this PR.

docs/blog/2018-08-09-swag-store/index.md

vladar · 2020-04-14T19:58:19Z

Sorry for the delay. I think we can merge this but need to resolve conflicts first and also figure out why the lint step fails. Mind taking a look? Then re-request a review and we'll ship it!

MichaelDeBoey · 2020-04-14T20:15:25Z

@vladar I just rebased my branch onto upstream/master

vladar · 2020-04-14T20:34:55Z

Yeah but for some reason lint still fails. Does it fail for you locally when running yarn lint:code ? Maybe we need to update eslint-config-prettier too.

MichaelDeBoey · 2020-04-14T20:51:43Z

@vladar I only get warnings when running yarn lint:code when I run it locally.

Will update eslint-config-prettier too, just to be sure 🙂

MichaelDeBoey · 2020-04-14T21:11:37Z

@vladar I've found a linting error, but CI is still failing 😕

MichaelDeBoey · 2020-04-14T21:47:41Z

@vladar I updated all .prettierrc files and ran Prettier on the full codebase.
I hope this will fix CI

MichaelDeBoey · 2020-04-14T22:27:10Z

@vladar Linting is passing, but still errors on unit tests.
Can't figure out what causes them to fail tho 😕

vladar · 2020-04-15T09:45:04Z

I think tests are failing because prettier output is captured in snapshots in several plugins. You need to run yarn run jest --updateSnapshot in the repo root to update them all.

Also, sadly, there are new conflicts. Looks like we must move fast after changes to be able to merge this 😄

vladar · 2020-04-15T09:53:50Z

docs/contributing/docs-contributions.md

@@ -173,7 +173,8 @@ To write a new GraphQL example, a Codesandbox project with a Gatsby site can be
 ```mdx
 Here's an example of a GraphQL query inline:

-<iframe src="https://711808k40x.sse.codesandbox.io/___graphql?query=query%20TitleQuery%20%7B%0A%20%20site%20%7B%0A%20%20%20%20siteMetadata%20%7B%0A%20%20%20%20%20%20title%0A%20%20%20%20%7D%0A%20%20%7D%0A%7D%0A&explorerIsOpen=false&operationName=TitleQuery" /> // highlight-line
+<iframe src="https://711808k40x.sse.codesandbox.io/___graphql?query=query%20TitleQuery%20%7B%0A%20%20site%20%7B%0A%20%20%20%20siteMetadata%20%7B%0A%20%20%20%20%20%20title%0A%20%20%20%20%7D%0A%20%20%7D%0A%7D%0A&explorerIsOpen=false&operationName=TitleQuery" /> //
+highlight-line


Moving highlight-line to the new line doesn't look right.

this got merged with the new line

Thanks for noticing! Created a PR to address this: #23140

MichaelDeBoey · 2020-04-15T11:05:09Z

@vladar I just rebased the branch and tried to run yarn test:update in the root, but that throws a lot of errors:

 Cannot find module 'gatsby-core-utils' from 'path-serializer.ts'

Can't figure out what causes this error tho 😕

vladar · 2020-04-15T11:42:27Z

Maybe try running yarn bootstrap first?

packages/gatsby-plugin-sharp/src/__tests__/__snapshots__/index.js.snap

package.json

This reverts commit 008eb99

packages/gatsby-plugin-sharp/src/__tests__/__snapshots__/index.js.snap

Co-Authored-By: Dima An <[email protected]>

vladar

Finally, it's green! Sorry for the churn but it's done now! Let's ship it while we can :) Great job! 💜

MichaelDeBoey · 2020-04-15T16:03:20Z

I'm happy it got green 🙂

* Update prettier to latest version * Run 'yarn format' from root of project * Remove prettier-ignore for nested markdown * Fix starters * Fix benchmarks * Fix examples * Fix integration-tests * Update eslint-config-prettier & eslint-plugin-prettier * Fix linting * Update all .prettierrc * Run Prettier on full codebase * Remove unnecessary .prettierrc & .prettierignore files * Update Prettier script * Update snapshots * Revert snapshot * Revert "Update Prettier script" This reverts commit 008eb99 * Update snapshot * Update docs/blog/2018-08-09-swag-store/index.md Co-Authored-By: Dima An <[email protected]> Co-authored-by: Dima An <[email protected]>

MichaelDeBoey requested review from a team as code owners March 23, 2020 23:42

vladar requested a review from tesseralis April 10, 2020 12:45

vladar suggested changes Apr 10, 2020

View reviewed changes

MichaelDeBoey force-pushed the update-prettier branch 3 times, most recently from 52464d4 to a31c4d7 Compare April 10, 2020 16:20

MichaelDeBoey requested a review from vladar April 10, 2020 16:21

tbntdima reviewed Apr 12, 2020

View reviewed changes

docs/blog/2018-08-09-swag-store/index.md Outdated Show resolved Hide resolved

MichaelDeBoey requested a review from tbntdima April 12, 2020 10:25

MichaelDeBoey force-pushed the update-prettier branch from 769b379 to 381865b Compare April 14, 2020 20:07

MichaelDeBoey requested a review from a team as a code owner April 14, 2020 21:46

vladar reviewed Apr 15, 2020

View reviewed changes

MichaelDeBoey added 8 commits April 15, 2020 12:54

Update prettier to latest version

84e034f

Run 'yarn format' from root of project

ad237b5

Remove prettier-ignore for nested markdown

1849d20

Fix starters

0f52ade

Fix benchmarks

4c7bcee

Fix examples

45f117e

Fix integration-tests

e6ee189

Update eslint-config-prettier & eslint-plugin-prettier

9f7c0cd

MichaelDeBoey added 4 commits April 15, 2020 12:55

Fix linting

2d89f03

Update all .prettierrc

2dff260

Run Prettier on full codebase

dd4e528

Remove unnecessary .prettierrc & .prettierignore files

36baef8

MichaelDeBoey force-pushed the update-prettier branch from 1d40082 to 36baef8 Compare April 15, 2020 10:55

Update Prettier script

008eb99

Update snapshots

71c8bbb

MichaelDeBoey force-pushed the update-prettier branch from d8f22a7 to 71c8bbb Compare April 15, 2020 12:14

vladar reviewed Apr 15, 2020

View reviewed changes

packages/gatsby-plugin-sharp/src/__tests__/__snapshots__/index.js.snap Outdated Show resolved Hide resolved

vladar reviewed Apr 15, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

MichaelDeBoey added 2 commits April 15, 2020 16:38

Revert snapshot

3ecee0a

Revert "Update Prettier script"

2830e6f

This reverts commit 008eb99

MichaelDeBoey requested a review from vladar April 15, 2020 14:40

vladar reviewed Apr 15, 2020

View reviewed changes

packages/gatsby-plugin-sharp/src/__tests__/__snapshots__/index.js.snap Outdated Show resolved Hide resolved

vladar reviewed Apr 15, 2020

View reviewed changes

packages/gatsby-plugin-sharp/src/__tests__/__snapshots__/index.js.snap Outdated Show resolved Hide resolved

MichaelDeBoey and others added 2 commits April 15, 2020 17:21

Update snapshot

6a5c020

Update docs/blog/2018-08-09-swag-store/index.md

4f74d58

Co-Authored-By: Dima An <[email protected]>

vladar approved these changes Apr 15, 2020

View reviewed changes

vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 15, 2020

gatsbybot merged commit ff911e2 into gatsbyjs:master Apr 15, 2020

MichaelDeBoey deleted the update-prettier branch April 15, 2020 16:03

This was referenced Apr 15, 2020

fix(docs): Prevent invalid prettier formatting in docs #23140

Merged

Add proseWrap: never option to prettier md parsing #22688

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update prettier #22520

Update prettier #22520

MichaelDeBoey commented Mar 23, 2020

vladar left a comment

vladar commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

vladar commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

vladar commented Apr 15, 2020

vladar Apr 15, 2020

muescha Apr 15, 2020

vladar Apr 15, 2020

MichaelDeBoey commented Apr 15, 2020

vladar commented Apr 15, 2020

vladar left a comment

MichaelDeBoey commented Apr 15, 2020

Update prettier #22520

Update prettier #22520

Conversation

MichaelDeBoey commented Mar 23, 2020

vladar left a comment

Choose a reason for hiding this comment

vladar commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

vladar commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

MichaelDeBoey commented Apr 14, 2020

vladar commented Apr 15, 2020

vladar Apr 15, 2020

Choose a reason for hiding this comment

muescha Apr 15, 2020

Choose a reason for hiding this comment

vladar Apr 15, 2020

Choose a reason for hiding this comment

MichaelDeBoey commented Apr 15, 2020

vladar commented Apr 15, 2020

vladar left a comment

Choose a reason for hiding this comment

MichaelDeBoey commented Apr 15, 2020