chore(www): Adjust for gatsby-design-tokens v2
#21276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump `gatsby-plugin-emotion` - remove `@emotion/core`, `@mdx-js/react` (ref. https://github.com/system-ui/theme-ui/blob/master/CHANGELOG.md#v030-2019-01-22) - `gatsby-design-tokens` currently has the version number provided by `gatsby-dev`, see #21240 for context)
Not a required change because `fonts.system` is still available, but IMO it's good to follow the `theme-ui` convention.
…ault We can omit the transition-property/keyword, defaults to `all`.
The next v of `gatsby-design-tokens` defines `speed.slow` as `500ms`, before it was `250`. Let's use the default of `250ms` instead. Snappier actually feels better.
|
Not w/o a youtube link: https://www.youtube.com/watch?v=CkIsxq44S0Y ✊ 😉 |
…okens-next # Conflicts: # www/package.json # www/src/components/email-capture-form-100days.js
…okens-next # Conflicts: # www/src/components/email-capture-form.js # www/src/components/search-form/algolia-styles.js
…okens-next # Conflicts: # www/src/components/layout.js # www/src/components/page-with-plugin-searchbar.js # www/src/components/showcase-details.js
…okens-next # Conflicts: # www/src/components/layout/layout-with-heading.js
sidharthachatterjee
approved these changes
Feb 11, 2020
sidharthachatterjee
added
the
bot: merge on green
delete-merged-branch
bot
deleted the
topics/www-gatsby-design-tokens-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Not ready for review/merge yet:
GTG ✌️gatsby-design-tokensneeds fixed first, see #21240 (comment).Ref. #21240. Should be good to merge by adjusting the
gatsby-design-tokensversion number afterv2of the latter has been published.build… works on my machine ;-)gatsby-plugin-emotion@emotion/core,@mdx-js/react(ref. https://github.com/system-ui/theme-ui/blob/master/CHANGELOG.md#v030-2019-01-22)TODO:fixedgatsby-design-tokenscurrently has the version number provided bygatsby-dev, see feat(gatsby-design-tokens): v2 #21240 for context)export { theme as default } from "gatsby-design-tokens/dist/theme-gatsbyjs-org"inwww/src/gatsby-plugin-theme-ui/indeximport { mediaQueries } from "gatsby-design-tokens/dist/theme-gatsbyjs-org"— not pretty, but that relative path togatsby-plugin-theme-uiwasn't either[email protected], see commits for details