Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix expected directory tree in _Shadowing other themes_ #19140

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

damycra
Copy link
Contributor

@damycra damycra commented Oct 30, 2019

Description

Amended expected directory tree, purely based on the preceding text.

@damycra damycra requested a review from a team as a code owner October 30, 2019 10:10
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We should probably change the tree so it reads like:

user-site
└── src
    └── gatsby-plugin-theme-ui
        └──index.js // highlight-line

This is the more "correct" shadow path for the Theme UI plugin since it doesn't need to be nested under gatsby-theme-blog. Do you mind updating it and the path specified in the paragraph above?

Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my last comment, didn't realize gatsby-theme-blog was using that path so this looks good to me. For the next major version of the theme we can flatten the pathing out.

Thanks!

@sidharthachatterjee sidharthachatterjee merged commit 67f9740 into gatsbyjs:master Nov 12, 2019
@gatsbot
Copy link

gatsbot bot commented Nov 12, 2019

Holy buckets, @damycra — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

rickiesmooth pushed a commit to rickiesmooth/gatsby that referenced this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants