Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Updated pronouns as per style guide #18680

Merged
merged 1 commit into from
Oct 15, 2019
Merged

chore(docs): Updated pronouns as per style guide #18680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/docs/asset-prefix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Once your application is built out, all assets will be automatically prefixed by
<script src="https://cdn.example.com/app-common-1234.js"></script>
```

However - if you were to deploy our application as-is, those assets would not be available! You can do this in a few ways, but the general approach will be to deploy the contents of the `public` folder to _both_ your core domain, and the CDN/asset prefix location.
However - if you were to deploy your application as-is, those assets would not be available! You can do this in a few ways, but the general approach will be to deploy the contents of the `public` folder to _both_ your core domain, and the CDN/asset prefix location.

### Using `onPostBuild`

Expand All @@ -55,7 +55,7 @@ exports.onPostBuild = async function onPostBuild() {

### Using `package.json` scripts

Additionally, you can use an npm script, which will let us use some command line interfaces/executables to perform some action, in this case, deploying our assets directory!
Additionally, you can use an npm script, which will let you use some command line interfaces/executables to perform some action, in this case, deploying your assets directory!

In this example, I'll use the `aws-cli` and `s3` to sync the `public` folder (containing all our assets) to the `s3` bucket.

Expand All @@ -68,7 +68,7 @@ In this example, I'll use the `aws-cli` and `s3` to sync the `public` folder (co
}
```

Now whenever the `build` script is invoked, e.g. `npm run build`, the `postbuild` script will be invoked _after_ the build completes, therefore making our assets available on a _separate_ domain after you have finished building out our application with prefixed assets.
Now whenever the `build` script is invoked, e.g. `npm run build`, the `postbuild` script will be invoked _after_ the build completes, therefore making your assets available on a _separate_ domain after you have finished building out your application with prefixed assets.

## Additional Considerations

Expand Down