refactor(gatsby-remark-code-repls): move config per provider #12936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
options: {
....
// Include CSS with matching name.
// This option only applies to REPLs that support it (eg Codepen).
// If set to `true`, when specifying `file1.js` as example file,
// it will try to inject the CSS in `file1.css` if the file exists,
// otherwise the default behaviour is preserved
includeMatchingCSS: false,
}
confict resolved Signed-off-by: Alessandro De Blasis <[email protected]>
Signed-off-by: Alessandro De Blasis <[email protected]>
Signed-off-by: Alessandro De Blasis <[email protected]>
Signed-off-by: Alessandro De Blasis <[email protected]>
…ring This is based upon suggestions in PR gatsbyjs#12110 review. Since there is a breaking change in the API, the version has been ⬆ Signed-off-by: Alessandro De Blasis <[email protected]>
Signed-off-by: Alessandro De Blasis <[email protected]>
Signed-off-by: Alessandro De Blasis <[email protected]>
DSchau
added
the
status: awaiting author response
wardpeet
reviewed
Apr 11, 2019
wardpeet
reviewed
Apr 11, 2019
Co-Authored-By: deblasis <[email protected]>
Awesome! You are welcome, happy to contribute back a little bit :) |
Apparently we merged to master the previous version that added the feature to include the matching css in the folder if present. This version is the refactored one which also improves the API surface by scoping the options depending on the REPL provider BREAKING CHANGE: The API surface is not backward compatible anymore as the options have been scoped per-provider as suggested during code-review gatsbyjs#12110
It will be incremented on publish, make sure it's a major version BREAKING CHANGE: API changes (read PR gatsbyjs#12936)
|
Hi @wardpeet , the PR that adds the feature was merged, this one is the API refactoring one. Let's remember to publish a major version since the API changed as suggested 😄 |
LekoArts
added
status: awaiting reviewer response
|
Hey @wardpeet 👋 Seems like this needs final approval, want to have a look? Thanks! |
|
I was testing this plugin on reactjs.org site and it seemed like it wasn't working great on windows machines so I made it work. Will publish when everything is green on new major |
wardpeet
approved these changes
Jun 25, 2019
wardpeet
changed the title
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it's possible to upload multiple files only by using CodeSandbox.
This PR adds an option that allows adding CSS files to CodePen examples by setting the css property in the payload object.
Ref: https://blog.codepen.io/documentation/api/prefill/
Matching CSS means that if the user is linking to example.js and the option is set to true, if example.css is present in the same directory, its content is sent to CodePen.
The default behaviour is left untouched
If the option is set to true and the matched file doesn't exist, nothing changes
tests included
Related Issues
This is based upon the suggestions in PR #12110 and it includes the breaking API changes