Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-cxs): Publish plugin files properly #11902

Merged
merged 1 commit into from
Feb 19, 2019
Merged

fix(gatsby-plugin-cxs): Publish plugin files properly #11902

merged 1 commit into from
Feb 19, 2019

Conversation

jaehwan-moon
Copy link
Contributor

Description

gatsby-ssr.js is not included in the NPM package. Due to two rules below in .npmignore

/*.js
!/index.js

After PR, the file will be published to the npm.

Related Issues

N/A

DSchau
DSchau approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes - yeah, this seems like a miss. Will merge this and get it published, thanks so much!

@DSchau DSchau merged commit db2f010 into gatsbyjs:master Feb 19, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 19, 2019

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@DSchau
Copy link
Contributor

DSchau commented Feb 19, 2019

Published as gatsby-plugin-cxs@2.0.5. See unpkg to validate it works 🎉

Thanks again!

@jaehwan-moon
Copy link
Contributor Author

It works now 😄 Thanks!

@jaehwan-moon jaehwan-moon deleted the fix-cxs-plugin-npmignore branch February 19, 2019 20:33
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
fix(gatsby-plugin-cxs): Publish plugin files properly (gatsbyjs#11902)
34f1c3c 
<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->
## Description
`gatsby-ssr.js` is not included in the NPM package. Due to two rules below in `.npmignore`
```
/*.js
!/index.js
```
After PR, the file will be published to the npm.

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaehwan-moon @DSchau