Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-sql): add new plugin to handle sql as a source #11100

Conversation

edgarrmondragon
Copy link

Description

Add a gatsby source plugin to get data from SQL databases.

Related Issues

Addresses #8714

@wardpeet wardpeet changed the title Topics/gatsby source sql feat(gatsby-source-sql)Topics/gatsby source sql Jan 16, 2019
@wardpeet wardpeet changed the title feat(gatsby-source-sql)Topics/gatsby source sql feat(gatsby-source-sql): add new plugin to handle sql as a source Jan 16, 2019
@LekoArts LekoArts added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Mar 25, 2019
@wardpeet wardpeet self-assigned this Apr 25, 2019
@wardpeet
Copy link
Contributor

wardpeet commented Apr 25, 2019

@mrfunnyshoes I have no idea how we missed this. Sorry for the delay! 🙏.

Is there like any demo database we can use to test this on? If not I'll just create one my own. Would it be possible to add some tests as well?

@wardpeet wardpeet removed their assignment Apr 25, 2019
@wardpeet wardpeet added status: awaiting author response Additional information has been requested from the author and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Apr 25, 2019
@sidharthachatterjee
Copy link
Contributor

Hey @mrfunnyshoes

First of all, this is really great work! Thank you for taking the time to build this and we apologise for not being able to take a look at this earlier.

While this is certainly a super useful source plugin, whether this should live in the gatsby repo or not is a subject that we've discussed. The conclusion we came to is that we would prefer to not include this in the core repo because:

  • It's a large and complex plugin that will be hard to maintain
  • There are simpler alternatives to GraphQL-izing SQL databases (like Prisma and Hasura for instance)

Because of the above, I'll be closing this for now but urge you to publish this in your own repo for everyone that would undeniably find this useful.

Please know that we really value having you as a contributor and look forward to having you on board for more PRs in the future! Thank you once again 💪 💜

@muescha
Copy link
Contributor

muescha commented Apr 17, 2020

FYI:
if someone search for this - the plugin is here available:

https://github.com/edgarrmondragon/gatsby-source-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants