Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use correct prefix for docs #11018

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

gurpreet-hanjra
Copy link
Contributor

Link to lifecycle documentation is missing /docs prefix from API specification. Add prefix to fix broken link.

Description

Related Issues

Link to lifecycle documentation is missing `/docs` prefix from API specification. Add prefix to fix broken link.
@gurpreet-hanjra gurpreet-hanjra requested a review from a team January 12, 2019 11:37
Copy link
Contributor

@AnushPatel AnushPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @gurpreet-hanjra.

@wardpeet wardpeet changed the title [gatsby-docs]: use correct prefix for docs fix(docs): use correct prefix for docs Jan 15, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing our docs navigation. It seems like this PR got merged somehow but Github didn't update it's status. I'll try to merge this one again, see what happens.

@wardpeet wardpeet merged commit 1d1244b into master Jan 15, 2019
@LekoArts LekoArts deleted the gurpreet-hanjra-patch-1 branch January 15, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants