Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link line 66 #10999

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Broken link line 66 #10999

merged 1 commit into from
Jan 11, 2019

Conversation

stuartflanagan
Copy link
Contributor

There is a broken link for the the section 'Starters that use gatsby-image'
Line: 66

It currently points here
I think it should point here

Description

Related Issues

@stuartflanagan
Broken link line 66
825355a 
There is a broken link for the the section 'Starters that use gatsby-image'
Line: 66

[It currently points here](/starter-showcase/?d=gatsby-image)
[I think it should point here]((/starters/?d=gatsby-image&v=2))
@stuartflanagan stuartflanagan requested a review from a team January 11, 2019 12:53
DSchau
DSchau approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DSchau DSchau merged commit e80c458 into gatsbyjs:master Jan 11, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 11, 2019

Holy buckets, @stuartflanagan — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@stuartflanagan
Copy link
Contributor Author

No problem,
Thank you for merging.
I look forward to sharing what we make with GatsbyJS

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@stuartflanagan @gpetrioli
Broken link line 66 (gatsbyjs#10999)
48e46ce 
There is a broken link for the the section 'Starters that use gatsby-image'
Line: 66

[It currently points here](/starter-showcase/?d=gatsby-image)
[I think it should point here]((/starters/?d=gatsby-image&v=2))

<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

<!-- Write a brief description of the changes introduced by this PR -->

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartflanagan @DSchau