Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(https): fix SSL naming error caused by @scoped package name #10847

Closed
wants to merge 3 commits into from
Closed

feat(https): fix SSL naming error caused by @scoped package name #10847

wants to merge 3 commits into from

Conversation

pqt
Copy link
Contributor

@pqt pqt commented Jan 5, 2019

converts the package name from @npm/package-name to npm--package-name when generating a development environment SSL cert.

  • Note that this change does not effect unscoped packages

fixes #10840

converts the package name from @npm/package-name to npm--package-name.

* Note that this change does not effect unscoped packages

fixes #10840
@pqt pqt requested a review from a team as a code owner January 5, 2019 08:04
@pqt
Copy link
Contributor Author

pqt commented Jan 5, 2019

Looks like this is failing from problems already happening in master.

Edit: I have corrected a lint error that I missed pertaining to the changed file.

@pqt pqt closed this Jan 6, 2019
@pqt
Copy link
Contributor Author

pqt commented Jan 6, 2019

Closed for #10863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--https fails if package name contains organization "@"
1 participant