Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing of GitHub and GitLab #10725

Merged
merged 1 commit into from
Dec 31, 2018
Merged

Fix casing of GitHub and GitLab #10725

merged 1 commit into from
Dec 31, 2018

Conversation

jbampton
Copy link
Contributor

@jbampton jbampton commented Dec 29, 2018 •
edited
Loading

Changes are:

  • GitHub not Github
  • GitHub not github
  • GitLab not Gitlab

@jbampton jbampton requested review from a team December 29, 2018 20:36
@jbampton jbampton changed the title Fix casing: GitHub not Github Fix casing of GitHub and GitLab Dec 29, 2018
ZYSzys
ZYSzys approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

pieh
pieh approved these changes Dec 31, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbampton!

@pieh pieh merged commit ba0cf60 into gatsbyjs:master Dec 31, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 31, 2018

Holy buckets, @jbampton — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@jbampton jbampton deleted the patch-1 branch December 31, 2018 10:22
@jbampton
Copy link
Contributor Author

Thanks a lot everyone !!

Happy New Year 👍

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@jbampton @gpetrioli
docs: Fix casing of GitHub and GitLab (gatsbyjs#10725)
19c1bb0 
Changes are:

- GitHub not Github 
- GitHub not github
- GitLab not Gitlab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@alessiodionisi alessiodionisi alessiodionisi approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbampton @pieh @alessiodionisi @ZYSzys