Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight-line on wrong line for tutorial part seven #10635

Merged
merged 2 commits into from
Dec 27, 2018

Conversation

wduntak
Copy link
Contributor

@wduntak wduntak commented Dec 23, 2018

Description

The hightlight-line comment is on the wrong line at line 77 and should be on line 76. Therefore, it is not showing the highlight of the new getNode function introduced as a parameter to the onCreateNode function.

Screenshot from tutorial on part seven:
screen shot 2018-12-23 at 12 49 14 pm

Related Issues

@wduntak wduntak requested a review from a team December 23, 2018 17:57
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wduntak!

@pieh pieh merged commit 940bc22 into gatsbyjs:master Dec 27, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 27, 2018

Holy buckets, @wduntak — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…ven (gatsbyjs#10635)

<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

The hightlight-line comment is on the wrong line at line 77 and should be on line 76. Therefore, it is not showing the highlight of the new getNode function introduced as a parameter to the onCreateNode function.

Screenshot from tutorial on part seven:
<img width="753" alt="screen shot 2018-12-23 at 12 49 14 pm" src="https://user-images.githubusercontent.com/9094342/50386304-1226f880-06b2-11e9-98f2-444bdc859db7.png">

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants