-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add development runtime tests #10473
Conversation
(some are skipped)
This actually mostly works really well, which is pretty cool. I've been able to validate the following functionality:
|
Will be used to test gatsbyjs#10528
@pieh or @m-allanson want to take a look at this tomorrow? Feeling like it's pretty done/ready! 😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some initial comments, but haven't had a chance to dig into this fully. Looking really nice though!
Running this locally it consistently fails on
This is a weird failure as |
(No idea why this wasn't automatically formatted)
I couldn't replicate that error @m-allanson when I was testing locally - so this is super weird to see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
In order to test PRs like #10455 more effectively, it makes a fair amount of sense to also test the development runtime, e.g.
gatsby develop
.What I want to test (and haven't been able to get quite working yet) are things like:
And other core functionalities of
develop
that we want to ensure remain working. I'll keep iterating on this PR next week, but wanted to get it up for some 👀 sooner rather than later.It could make sense to test this stuff as part of the production runtime, and just create separate test scripts, but I thought this was a little cleaner. Opinions more than welcome!