Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: create gatsby-plugin-aphrodite #8709

Closed
DSchau opened this issue Oct 2, 2018 · 5 comments
Closed

[feat]: create gatsby-plugin-aphrodite #8709

DSchau opened this issue Oct 2, 2018 · 5 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby

Comments

@DSchau
Copy link
Contributor

DSchau commented Oct 2, 2018

Summary

Aphrodite is a great plugin for CSS in JS w/ React. Let's create a plugin so that others can get some SSR benefits and CSS hydration with Gatsby.

Motivation

  • We have a number of other plugins which implement similar functionality, e.g. gatsby-plugin-emotion, gatsby-plugin-styled-components, etc.
  • We don't want to prohibit anyone from using Gatsby because their preferred styling solution isn't supported, and Gatsby is extremely pluggable to enable this :)

General Approach

  • Create packages/gatsby-plugin-aphrodite (see previously mentioned CSS in JS libraries for more info/boilerplate)
  • Implement the SSR API from Aphrodite
  • PR and experience the ❤️ from all of those who use and like Aphrodite
@DSchau DSchau added Hacktoberfest good first issue Issue that doesn't require previous experience with Gatsby labels Oct 2, 2018
@thisizkp
Copy link
Contributor

thisizkp commented Oct 3, 2018

I would love to work on this.

@DSchau
Copy link
Contributor Author

DSchau commented Oct 3, 2018

@thisizkp we would love if you did!

Let any of us know @gatsbyjs/core if we can help with anything!

@ivandevp
Copy link
Contributor

ivandevp commented Oct 5, 2018

Hey @thisizkp , how are you going with this feat? I would like to help you if possible 😃

@thisizkp
Copy link
Contributor

thisizkp commented Oct 6, 2018

@ivandevp thanks for asking, I've kind of stuck at some error.

I think I need to use wrapRootElement instead of replaceRenderer. Will spend some more time debugging and learning more about it, if couldn't will let you know :)

Found the issue, fixed it and raised a PR.

DSchau pushed a commit that referenced this issue Oct 10, 2018
* gatsby plugin aphrodite

* chore: decrement peer dep version; update readme

* chore: tweak line break again
DSchau added a commit that referenced this issue Oct 10, 2018
DSchau added a commit that referenced this issue Oct 10, 2018
#9007)

This reverts commit 4a9e927, which added support for gatsby-plugin-aphrodite (which already exists!)
@DSchau
Copy link
Contributor Author

DSchau commented Oct 10, 2018

Done in #8883, which has (unfortunately) since been reverted.

This plugin already exists, see gatsby-plugin-aphrodite.

Thanks for the interest here, and go use that plugin if you're interested. Thanks to everyone who contributed/replied!

@DSchau DSchau closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby
Projects
None yet
Development

No branches or pull requests

3 participants