-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[www/showcase] "Showcase" entry uses square image as meta twitter:image
#14469
Comments
Hey! I'd like to give this a shot if possible. |
Been trying to get started on this but I'm not exactly sure how. This is my first issue! If you could provide me with some extra context please. |
@superhawk610 How can I run this on dev mode, I tried running |
Watcher issues can be resolved by #11406 (comment). as @superhawk610 mentioned the code is gatsby/www/src/components/showcase-details.js Lines 255 to 268 in 542cdb2
And I believe we want to change which also means you'll need to add publicURL to our graphql query gatsby/www/src/components/showcase-details.js Lines 125 to 131 in a82a9ad
|
@wardpeet I can take this. I was in fact looking for the original url for the image, as it was not possible to use the image urls from srcset of the main image shown. |
@superhawk610 Thanks for the clarification! I think I got this. |
Sorry for only being able to follow up here today! Thanks for helping out everybody! |
* showcase metatag images size fix [#14469] * Rm `publicURL` from static query * Pull resized image * Don't create a square thumbnail, but a 1.91:1 landscape crop * Tell Twitter to use the `summary_large_image` format * Provide correct dimensions (`og:image:width/height`) * Add `og:title`, adjust `<title>`… …following what we do for starter detail pages (e.g. `/starters/gatsbyjs/gatsby-starter-blog/`)
* showcase metatag images size fix [gatsbyjs#14469] * Rm `publicURL` from static query * Pull resized image * Don't create a square thumbnail, but a 1.91:1 landscape crop * Tell Twitter to use the `summary_large_image` format * Provide correct dimensions (`og:image:width/height`) * Add `og:title`, adjust `<title>`… …following what we do for starter detail pages (e.g. `/starters/gatsbyjs/gatsby-starter-blog/`)
E.g. for https://www.gatsbyjs.org/showcase/airbnb.io/ we are setting
as
twitter:image
.Let's share the uncropped image instead:
The text was updated successfully, but these errors were encountered: