fix: clear tracked queries when deleting stale page-data files (#29431)

* fix: clear tracked queries when deleting stale page-data files * add comment about hot-fix nature of added action
gatsbyjs · Feb 10, 2021 · 478cf68 · 478cf68
1 parent e567aa8
commit 478cf68
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/packages/gatsby/src/redux/reducers/queries.ts b/packages/gatsby/src/redux/reducers/queries.ts
@@ -90,6 +90,20 @@ export function queriesReducer(
       state.deletedQueries.add(action.payload.path)
       return state
     }
+    case `DELETED_STALE_PAGE_DATA_FILES`: {
+      // this action is a hack/hot fix
+      // it should be removed/reverted when we start persisting pages state
+      for (const queryId of action.payload.pagePathsToClear) {
+        for (const component of state.trackedComponents.values()) {
+          component.pages.delete(queryId)
+        }
+        state = clearNodeDependencies(state, queryId)
+        state = clearConnectionDependencies(state, queryId)
+        state.trackedQueries.delete(queryId)
+      }
+
+      return state
+    }
     case `API_FINISHED`: {
       if (action.payload.apiName !== `createPages`) {
         return state

diff --git a/packages/gatsby/src/redux/types.ts b/packages/gatsby/src/redux/types.ts
@@ -352,6 +352,7 @@ export type ActionsUnion =
   | IDisableTypeInferenceAction
   | ISetProgramAction
   | ISetProgramExtensions
+  | IDeletedStalePageDataFiles
 
 export interface IApiFinishedAction {
   type: `API_FINISHED`
@@ -804,3 +805,10 @@ interface ISetProgramExtensions {
   type: `SET_PROGRAM_EXTENSIONS`
   payload: Array<string>
 }
+
+interface IDeletedStalePageDataFiles {
+  type: `DELETED_STALE_PAGE_DATA_FILES`
+  payload: {
+    pagePathsToClear: Set<string>
+  }
+}
diff --git a/packages/gatsby/src/utils/page-data.ts b/packages/gatsby/src/utils/page-data.ts
@@ -256,10 +256,20 @@ export async function handleStalePageData(): Promise<void> {
   })
 
   const deletionPromises: Array<Promise<void>> = []
-  pageDataFilesFromPreviousBuilds.forEach(pageDataFilePath => {
+  const pagePathsToClear = new Set<string>()
+  for (const pageDataFilePath of pageDataFilesFromPreviousBuilds) {
     if (!expectedPageDataFiles.has(pageDataFilePath)) {
+      const stalePageDataContent = await fs.readJson(pageDataFilePath)
+      pagePathsToClear.add(stalePageDataContent.path)
       deletionPromises.push(fs.remove(pageDataFilePath))
     }
+  }
+
+  store.dispatch({
+    type: `DELETED_STALE_PAGE_DATA_FILES`,
+    payload: {
+      pagePathsToClear,
+    },
   })
 
   await Promise.all(deletionPromises)