fix(gatsby): remove redundant dispatch of query extraction error (#28676

) (#28744) * fix(gatsby): remove redundant query extraction error dispatch * Warning message (cherry picked from commit 1d7dc76) Co-authored-by: Vladimir Razuvaev <[email protected]>
gatsbyjs · Dec 23, 2020 · 0b8ea51 · 0b8ea51
1 parent 5a0489d
commit 0b8ea51
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 4 deletions.
diff --git a/e2e-tests/mdx/gatsby-config.js b/e2e-tests/mdx/gatsby-config.js
@@ -17,6 +17,7 @@ module.exports = {
         path: `${__dirname}/src/posts`,
       },
     },
+    `gatsby-plugin-test-regression1`,
     {
       resolve: `gatsby-plugin-mdx`,
       options: {

diff --git a/e2e-tests/mdx/plugins/gatsby-plugin-test-regression1/gatsby-node.js b/e2e-tests/mdx/plugins/gatsby-plugin-test-regression1/gatsby-node.js
@@ -0,0 +1,2 @@
+// See pages/regressions/index.mdx
+exports.preprocessSource = args => args.contents
diff --git a/e2e-tests/mdx/plugins/gatsby-plugin-test-regression1/package.json b/e2e-tests/mdx/plugins/gatsby-plugin-test-regression1/package.json
@@ -0,0 +1,3 @@
+{
+  "name": "gatsby-plugin-test-regression1"
+}
diff --git a/e2e-tests/mdx/src/pages/regressions/index.mdx b/e2e-tests/mdx/src/pages/regressions/index.mdx
@@ -0,0 +1,10 @@
+This is a regression test for query extraction bug in Gatsby.
+
+All of the following is required to hit this bug:
+
+1. There should be at least one other plugin implementing `preprocessSource`
+2. This plugin must be listed before `gatsby-plugin-mdx` in `gatsby-config.js`
+3. MDX file must contain word `graphql`
+
+!Important, do not remove the next line!
+`graphql`
diff --git a/packages/gatsby/src/query/file-parser.js b/packages/gatsby/src/query/file-parser.js
@@ -92,10 +92,7 @@ async function parseToAst(filePath, fileStr, { parentSpan, addError } = {}) {
         ast = tmp
         break
       } catch (error) {
-        boundActionCreators.queryExtractionGraphQLError({
-          componentPath: filePath,
-        })
-        continue
+        // We emit the actual error below if every transpiled variant fails to parse
       }
     }
     if (ast === undefined) {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// See pages/regressions/index.mdx
		exports.preprocessSource = args => args.contents