Small Updates to Padding Free Branch #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fabianlim
commented
Jun 11, 2025
fabianlim
commented
- support parquet data files
- support additional model args
Owner
|
LGTM. Additional args are for NoPE/z_loss? |
garrett361
approved these changes
Jun 11, 2025
Owner
|
I assume the |
Collaborator
Author
|
good point, i think it should be space delimited, but I need to check |
Collaborator
Author
|
@garrett361 i tested it takes a space delimited sequence of args |
dangxuanhong
approved these changes
Jun 11, 2025
Collaborator
dangxuanhong
left a comment
dangxuanhong
left a comment
There was a problem hiding this comment.
LGTM, thanks @fabianlim
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.